Remove dead code: unused macros and unreachable breaks#189
Draft
toddr-bot wants to merge 1 commit into
Draft
Conversation
- Remove KEY_KEY, PADDING_KEY, HASH_KEY macros — vestiges of an older design that stored RSA data in a Perl hash instead of the current C struct. No code references them. - Remove unreachable break statements after return in get_digest_length() — each case returns directly, making the subsequent break dead code. PACKAGE_NAME is retained: the XS typemap references it for blessed reference type checking. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove unused preprocessor macros and unreachable break statements.
Why
KEY_KEY,PADDING_KEY, andHASH_KEYare relics from an older design where RSA data was stored in a Perl hash. The current code uses a C struct (rsaData) and none of these macros are referenced.PACKAGE_NAMEis retained — the XS typemap uses it for type checking.The
breakstatements afterreturninget_digest_length()are dead code (unreachable after return).How
#definemacros and their comment blockbreakstatements inget_digest_length()Testing
🤖 Generated with Claude Code